Feat/add in experiment #103
Merged
+83
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yabuta
reviewed
Jun 11, 2024
| @@ -137,14 +160,28 @@ def send_data(self, display_key, data_key): | |||
| sender.send(data, ack_query_ack, ack_data_chunk) | |||
|
|
|||
| def trigger_external_signage(self, request, response): | |||
| if not self._external_signage_available: | |||
| return response | |||
| if request.data: | |||
There was a problem hiding this comment.
すみません、ここにself._settings["in_experiment"] == Trueなら表示を変えない条件を入れてください
実験中の場合は自動走行中でもずっと「実証実験中」の表示にしたいです
| @@ -114,15 +120,32 @@ def __init__(self, node): | |||
| "back": self._load_display_data(self.protocol.back, package_path), | |||
| "side": self._load_display_data(self.protocol.side, package_path), | |||
| } | |||
| self._settings_file = "/home/" + os.environ.get("USER") + "/settings.json" | |||
There was a problem hiding this comment.
今回ではなくてもいいかもですが設定ファイルを置く場所は.envなどで指定できるようにして用途によっておく場所を変更できるようにできると良いかもしれませんね
There was a problem hiding this comment.
なるほど、そうですね。
ansibleで追加してもいいと思います。
Signed-off-by: tkhmy <[email protected]>
Signed-off-by: tkhmy <[email protected]>
Signed-off-by: tkhmy <[email protected]>
Signed-off-by: tkhmy <[email protected]>
Signed-off-by: tkhmy <[email protected]>
tkhmy
force-pushed
the
feat/add_in_experiment
branch
from
ed23869 to
7c0c65e
Compare
Signed-off-by: tkhmy <[email protected]>
Signed-off-by: tkhmy <[email protected]>
yabuta
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue(required)
Description(required)
Review Procedure(required)
Related PR(optional)
Pre-Review Checklist for the PR Author
PR Author should check the checkboxes below when creating the PR.
If you are adding new package following items are required:
Checklist for the PR Reviewer
Reviewers should check the checkboxes below before approval.
Post-Review Checklist for the PR Author
PR Author should check the checkboxes below before merging.